Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Switch from sphinx to mkdocs #57

Closed
felixhoffmnn opened this issue Oct 20, 2022 · 8 comments
Closed

[Feature] Switch from sphinx to mkdocs #57

felixhoffmnn opened this issue Oct 20, 2022 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation feature New feature or request

Comments

@felixhoffmnn
Copy link

Summarize the feature
In my opinion, Mkdocs is a more modern and easier approach to documentation in python.

Mkdocs is also compatible with readthedocs.

Example of the feature
FastAPI, mkdocs-material

Additional context
None

@felixhoffmnn felixhoffmnn added the feature New feature or request label Oct 20, 2022
@felixhoffmnn
Copy link
Author

felixhoffmnn commented Oct 20, 2022

@zaanposni Could you add the link (https://vvspy.readthedocs.io/en/latest/) to repository description (in the link section of course)? I think it would be a bit more convenient.

@felixhoffmnn
Copy link
Author

When switching from sphinx to Mkdocs it would also be required to update all doc strings because they are not compatible 100% currently.

@zaanposni
Copy link
Owner

I agree that mkdocs looks more modern and should be used.
I have added the link to the repository description.

When switching from sphinx to Mkdocs it would also be required to update all doc strings because they are not compatible 100% currently.

Would be good to review/rework those doc strings anyway 😄

@zaanposni zaanposni added the documentation Improvements or additions to documentation label Oct 21, 2022
@zaanposni
Copy link
Owner

@felixhoffmnn do you want to work on this issue?
In the meantime I could look into #55

@felixhoffmnn
Copy link
Author

Sounds good. Yeah, you can assign me 😃

I was slightly over-motivated and started working on #55, #56, and #57. You can look through the current progress here: https://github.com/felixhoffmnn/vvspy. If there appears anything that is not wanted or not in this project's scope, please comment on the regarding commit.

@zaanposni
Copy link
Owner

Hi @felixhoffmnn as you may have guessed I am currently a bit busy ^.^
I plan to get back to this project next weekend at the latest.

The only thing I dont like is the use of jupyter notebooks as examples and the new logging framework as those things introduce unnecessary third party dependencies.

I would have to go through your changes more carefully once you feel like they are ready to review. Maybe you should split them up in smaller PRs too ^.^

@zaanposni
Copy link
Owner

zaanposni commented Nov 1, 2022

Again, I can work on issues too if you want me to. No need to do everything on your own.

If you want: Feel free to add me on discord for easier and direct communication: zaanposni#9295

@felixhoffmnn felixhoffmnn mentioned this issue Nov 17, 2022
4 tasks
@zaanposni
Copy link
Owner

wont be fixed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants