Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bower tasks to build task #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

juandopazo
Copy link
Member

grunt build should call bower install before yogi build and the rest of the build process.

@ericf
Copy link
Member

ericf commented Dec 17, 2013

@juandopazo why are you removing the bower_components dir? Can't we simply leave that there?

@juandopazo
Copy link
Member Author

I thought it would make sense to clean up after ourselves, mostly because I don{t know all the details of what happens after a build.

@ericf
Copy link
Member

ericf commented Dec 17, 2013

This would be like going in and removing the node_modules/ directory. I think we should leave it because then bower ls shows which version of Pure we're using. And in the future—whenever we get rid of the build/ dir—we'll need the bower_components/ dir there because it would be used every time a developer builds.

@juandopazo
Copy link
Member Author

Ok. Rolling back then!

@ericf
Copy link
Member

ericf commented Feb 28, 2014

@juandopazo You want to keep ypromise out of YUI's src/ dir, correct? If so go ahead and merge + release this — I gave you push access to this repo and publish access to the npm package.

@juandopazo
Copy link
Member Author

I may have to do more than that, since ypromise contains YUIDoc information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants