Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add tldr section for coredb contributors #22172
[docs] Add tldr section for coredb contributors #22172
Changes from 50 commits
fbbfefe
0933830
22fb457
e91cb8f
8ecb8ca
a58586e
ec198e3
35b88a0
acf790a
3a4aaab
021ecd2
20482d9
8d4c7d5
56c90da
7a64c9b
580de7a
23d5a13
3e8a87c
a27fd61
354ef15
3b1d9ca
d8db185
746a0f4
fa199e3
16200d8
94e0262
0adb68e
4daa11b
0d7f02b
c27a585
cfacaa3
7bce825
0abcedf
ad446ab
60bfc5d
50ae54c
dbcc33a
0127701
3955d4c
e9a6c7d
d597036
f2c57cb
0abc611
a9a2fd6
a43326e
a6325dd
8683ffe
e5a62d2
81ef903
f32512c
a4a764f
d0a8c23
7cc5695
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some systems may use Python 3.10 or 3.11. Can we remove the hard-coded 3.9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no
python310
orpython311
package yet on Almalinux 8 as far as I can tell. Also, this is based off of the python section below, so changing both copies of this could be considered out of scope of this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of piping output to /dev/null, maybe pass the -s / --silent option to curl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-s is used. sudo tee is piping to /dev/null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need support for building on Ubuntu 20.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no point in removing it yet