bugfix: only cache successfult record #22019
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, yb will cache 60s (both good and bad record).
But DNS resolve use udp by default(boost:asio will using glibc getaddrinfo), sometimes the DNS rsp packet may lost, in this case yb will cache 'Host not found (authoritative)'.
For example, the DNS rsp packet is drop by network stack
Yb DNS resolve timeout, but will cache 60s error record(During this time period, the pod is ok). But yb will believe 'Host not found', which will cause the instance not available and some latency
