[BACKPORT 2.6][platform] Restart pod if the configuration changes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds checksum of the configs.yaml file to pod metadata as annotation. This causes it to change if there are any changes in the configuration, and results in a restart of the pod. https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments - Moving the global-config outside from configs.yaml, as it has a random string in it, which causes a restart everytime as the checksum keeps changing. Test plan: - Deployed platform chart in a Kubernetes cluster without this change. - Upgraded the Helm release with this change (the pod restarts as expected). - Add --set helm.timeout=1000 during the helm upgrade (the pod restarts as expected) - Did another upgrade with same command as above (the pod does not restart as the configuration is the same). Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
bhavin192
force-pushed
the
2.6-cm-restart-8240
branch
from
5dc6aba
to
7f52439
Compare
skorobogatydmitry
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotation. This causes it to change if there are any changes in the
configuration, and results in a restart of the pod.
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments
random string in it, which causes a restart everytime as the
checksum keeps changing.
Test plan:
expected).
restarts as expected)
restart as the configuration is the same).