-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop filling home directory with garbage #578
base: main
Are you sure you want to change the base?
Conversation
NBD tests creates temporary files in home directory even without executing tests. This file name is used for socket - regular file isn't required. Always place them in /tmp - stop filling home with garbage.
Попробовал запустить патч, наткнулся на проблему из-за которой так не сделали с самого начала: Падение теста выглядит так:
Полезные ошибки в логах так:
Связано это с этим биндом: https://github.com/ytsaurus/ytsaurus/blob/main/yt/yt/server/job_proxy/job_proxy.cpp#L1148. Есть тикет в PORTO, чтобы это поправить. |
@yalekseev – use English please. Could we consider making this bind optional? And disable it in tests. I hope that I understand the problem correctly. |
Playing dirty tricks with obscure binds isn't better than sticking socket into random unexpected directories, like "/tmp" or home. Inside container "/run" or "/dev" are more suited places for that. It don't have to be rootfs - it is better to add separate tmpfs volume for such interconnections. Inside container it could be mounted as "/dev/something", and in host hypervisor already knows short direct path to it. |
NBD tests creates temporary files in home directory even without executing tests.
This file name is used for socket - regular file isn't required.
Always place them in /tmp - stop filling home with garbage.