Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile configuration file for API and CLI #576

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

thenno
Copy link
Contributor

@thenno thenno commented May 10, 2024

#90

Added support for profiles to python sdk / cli's config.

Example:

{
    "config_version": 2,
        "profiles": {
            "profile1": {
            "token": "token1"
        },
        "profile2": {
            "token": "token2"
        }
    }
}

Default values has not been implemented because we didn't agree on what they should look like.
The old approach without profiles still remains.

@Kontakter Kontakter requested a review from denvr May 10, 2024 11:53
@@ -19,6 +19,8 @@
# pydoc :: default_config :: begin

DEFAULT_WRITE_CHUNK_SIZE = 128 * common.MB
DEFAULT_GLOBAL_CONFIG_PATH = "/etc/ytclient.conf"
DEFAULT_USER_CONFIG_PATH = ".yt/config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe ~/.yt/config and expandpath later? this relative path looks a bit confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to rename it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants