Add the ability to proxy metrics via http proxy #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gritukan
reviewed
May 21, 2024
| http_proxy_config = configs["http_proxy"][0] | ||
| scheduler_config = configs["scheduler"][0] | ||
|
|
||
|
|
|
|
||
| @authors("achulkov2") | ||
| def test_formats(self): | ||
| # Json (default) |
|
|
||
| # Solomon shards (which are also instance labels). | ||
| assert self.get_instance_count(self.get_sensors(params={"instance_shard": "all"})) == 3 | ||
| assert self.get_instance_count(self.get_sensors(params={"instance_shard": "we-miss-prime"})) == 0 |
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| TComponentDiscoverer::TComponentDiscoverer(IClientPtr client, TMasterReadOptions masterReadOptions, TDuration proxyDeathAge) |
There was a problem hiding this comment.
I'd suggest split arguments by lines
| .ValueOrThrow(); | ||
| auto rspList = ConvertToNode(rsp)->AsList(); | ||
|
|
||
| std::vector<TYtInstance> instances; |
| return pullHeaders; | ||
| } | ||
|
|
||
| TCgiParameters TSolomonProxy::PreparePullParameters(const TCgiParameters& params) |
There was a problem hiding this comment.
nip: params -> parameters globally?
| return filteredEndpoints; | ||
| } | ||
|
|
||
| std::vector<TString> TSolomonProxy::CollectEndpoints(const TCgiParameters& params, int shard_index, int shard_count) const |
| auto reqUrlRef = req->GetUrl(); | ||
| TCgiParameters params(reqUrlRef.RawQuery); | ||
|
|
||
| auto shard_index = ParseIntegerParameter(params, ShardIndexParameterName, /*defaultValue*/ 0); |
|
|
||
| // TODO(achulkov2): Ideally, we would want some sort of memory accounting here. | ||
| if (std::ssize(filteredEndpoints) > Config_->MaxEndpointsPerRequest) { | ||
| THROW_ERROR_EXCEPTION("Cannot pull sensors from %v endpoints at once, please retry the request with a larger shard count", filteredEndpoints.size()) |
| << TErrorAttribute("max_endpoints_per_request", Config_->MaxEndpointsPerRequest); | ||
| } | ||
|
|
||
| std::vector<TFuture<IResponsePtr>> asyncPullResponses; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #549. HTTP proxies now have an additional
/solomon_proxy/sensorshandle, which can be used to collect metrics from internal YT components without network access to their monitoring ports.There are quite a few TODO-s left, but they are immediately needed and can be isolated to separate pull requests.
Additional endpoint providers (for CHYT cliques, for example) will be implemented later.