Managed CRI docker image cache #567
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gritukan
reviewed
May 2, 2024
koct9i
force-pushed
the
cri-image-cache
branch
2 times, most recently
from
7cb135a
to
e9707da
Compare
Weighted cookie allows to reclaim space before inserting new value. This helps to avoid temporary overcommit. Cookie weight don't have to exactly match weight of final value, and could be updated during insertion.
This helps to avoid overcommit by pinned entries which could live arbitrary long time after removing from cache. Also this provides better estimate for end of "last recent use" because "touch" happens at the beginning of use not at at the end.
Without unused "error" argument retry does not happens. Fixes: c437f3b ("Cosmetics")
This is SLRU cache which tracks docker images and their tags and digests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add weight for cookies in async SLRU cache
Weighted cookie allows to reclaim space before inserting new value.
This helps to avoid temporary overcommit.
Cookie weight don't have to exactly match weight of final value,
and could be updated during insertion.
Add async SLRU method IsMustRetain to detect and preserve useful entries
Always retry chained docker image pull
Without unused "error" argument retry does not happens.
Fixes: c437f3b ("Cosmetics")
Add CRI Image Cache
This is SLRU cache which tracks docker images and their tags and digests.