Add weight for cookies in async SLRU cache #545
Closed
+224
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gritukan
reviewed
Apr 23, 2024
koct9i
force-pushed
the
cookie-weight-for-async-slru-cache
branch
from
96c6e32
to
00d9ae9
Compare
maxim-babenko
requested changes
May 15, 2024
maxim-babenko
requested changes
May 22, 2024
koct9i
force-pushed
the
cookie-weight-for-async-slru-cache
branch
from
f88f8b7
to
310242c
Compare
Weighted cookie allows to reclaim space before inserting new value. This helps to avoid temporary overcommit. Cookie weight don't have to exactly match weight of final value, and could be updated during insertion.
koct9i
force-pushed
the
cookie-weight-for-async-slru-cache
branch
from
310242c
to
9a3a150
Compare
|
Shipped! |
maxim-babenko
approved these changes
May 23, 2024
|
@maxim-babenko has imported your pull request. If you are a Yandex employee, you can view this diff. |
|
✅ This pull request is being closed because it has been successfully merged. |
robot-piglet
pushed a commit
that referenced
this pull request
May 27, 2024
Weighted cookie allows to reclaim space before inserting new value. This helps to avoid temporary overcommit. Cookie weight don't have to exactly match weight of final value, and could be updated during insertion. --- d10ca4aee44e6399d55fad57f6bb36003cc7ad08 Pull Request resolved: #545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weighted cookie allows to reclaim space before inserting new value.
This helps to avoid temporary overcommit.
Cookie weight don't have to exactly match weight of final value,
and could be updated during insertion.