Fix maven assembly plugin configuration #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextokarew
requested changes
Apr 17, 2024
| @@ -57,6 +57,7 @@ | |||
| <plugin> | |||
| <artifactId>maven-assembly-plugin</artifactId> | |||
| <configuration> | |||
| <tarLongFileMode>posix</tarLongFileMode> | |||
| @@ -44,6 +44,7 @@ | |||
| <plugin> | |||
| <artifactId>maven-assembly-plugin</artifactId> | |||
| <configuration> | |||
| <tarLongFileMode>posix</tarLongFileMode> | |||
| @@ -14,14 +14,15 @@ private[spark] class YTsaurusClusterApplication extends SparkApplication with Lo | |||
|
|
|||
| override def start(args: Array[String], conf: SparkConf): Unit = { | |||
| val masterURL = conf.get("spark.master") | |||
| val ytProxy = YTsaurusUtils.parseMasterUrl(masterURL) | |||
| val ytProxy = conf.get("spark.hadoop.yt.clientProxy", YTsaurusUtils.parseMasterUrl(masterURL)) | |||
There was a problem hiding this comment.
Протекло из другого ПР
| @@ -202,6 +202,9 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-assembly-plugin</artifactId> | |||
| <version>3.1.0</version> | |||
| <configuration> | |||
There was a problem hiding this comment.
В yt/spark/spark/* мы не принимаем доработки, т.к. скоро это будет удалено
| @@ -96,7 +96,7 @@ object PythonRunner { | |||
| try { | |||
| val process = builder.start() | |||
|
|
|||
| new RedirectThread(process.getInputStream, System.out, "redirect output").start() | |||
| new RedirectThread(process.getInputStream, System.err, "redirect output").start() | |||
There was a problem hiding this comment.
Я это сделаю в ближайшее время немного другим способом, войдёт в ближайший релиз.
mamogaaa
force-pushed
the
fix-maven-assembly-plugin-configuration
branch
from
848bf12
to
3ae5956
Compare
|
Partly implemented in another commits, partly declined because of removal of Spark fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.