Cleanup disk quota options #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gritukan
reviewed
Apr 12, 2024
Kontakter
approved these changes
Apr 13, 2024
|
@Kontakter has imported your pull request. If you are a Yandex employee, you can view this diff. |
Kontakter
requested changes
Apr 13, 2024
There was a problem hiding this comment.
There are compilation errors:
$(SOURCE_ROOT)/yt/yt/server/node/exec_node/job.cpp:2729:38: error: use of undeclared identifier 'Config_'
options.EnableSandboxDiskQuota = Config_->SlotManager->EnableDiskQuota;
...
$(SOURCE_ROOT)/yt/yt/server/node/data_node/unittests/volume_manager_ut.cpp:352:10: error: field designator 'HasRootFSQuota' does not refer to any field in type 'TUserSandboxOptions'
.HasRootFSQuota = true,
^
$(SOURCE_ROOT)/yt/yt/server/node/data_node/unittests/volume_manager_ut.cpp:353:10: error: field designator 'EnableDiskQuota' does not refer to any field in type 'TUserSandboxOptions'
.EnableDiskQuota = false
koct9i
force-pushed
the
cleanup-disk-quota-options
branch
2 times, most recently
from
4de2ca6
to
fff1429
Compare
koct9i
commented
Apr 15, 2024
koct9i
commented
Apr 15, 2024
koct9i
force-pushed
the
cleanup-disk-quota-options
branch
from
fff1429
to
8e719e8
Compare
Kontakter
approved these changes
May 21, 2024
|
@Kontakter has imported your pull request. If you are a Yandex employee, you can view this diff. |
Kontakter
requested changes
May 21, 2024
There was a problem hiding this comment.
There are still some build errors:
yt/yt/server/node/data_node/unittests/volume_manager_ut.cpp:352:10: error: field designator 'HasRootFSQuota' does not refer to any field in type 'TUserSandboxOptions'
.HasRootFSQuota = true,
^
yt/yt/server/node/data_node/unittests/volume_manager_ut.cpp:353:10: error: field designator 'EnableDiskQuota' does not refer to any field in type 'TUserSandboxOptions'
.EnableDiskQuota = false
^
2 errors generated.
Add slot location option for enabling disk quota for sandbox directories. It is implemented as user disk quota or as porto (project) quota volume. Root volume quota works independently but enforces the same limits. It is implemented only for porto volume.
This file not in OS |
koct9i
force-pushed
the
cleanup-disk-quota-options
branch
from
8e719e8
to
9fc1f9f
Compare
Kontakter
approved these changes
May 22, 2024
|
@Kontakter has imported your pull request. If you are a Yandex employee, you can view this diff. |
|
✅ This pull request is being closed because it has been successfully merged. |
robot-piglet
pushed a commit
that referenced
this pull request
May 22, 2024
Add separate option for enabling disk quota for (slot) sandbox directory. It is implemented as user quota or as porto (project) quota volume. Root volume quota works independently but enforces the same limits. It is implemented only for porto volume. --- ec6078e4ebf548666ea038b666a07e58ca36d2a4 Pull Request resolved: #528
robot-piglet
pushed a commit
that referenced
this pull request
May 25, 2024
Add separate option for enabling disk quota for (slot) sandbox directory. It is implemented as user quota or as porto (project) quota volume. Root volume quota works independently but enforces the same limits. It is implemented only for porto volume. --- 2ed74abcbc5912ed092f6ce6e5ecdc7ca0f4d791 Pull Request resolved: #528
robot-piglet
pushed a commit
that referenced
this pull request
May 25, 2024
Add separate option for enabling disk quota for (slot) sandbox directory. It is implemented as user quota or as porto (project) quota volume. Root volume quota works independently but enforces the same limits. It is implemented only for porto volume. --- 46ed6938b6ac2e446938d84ef8b8158b39b2c8d2 Pull Request resolved: #528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add slot location option for enabling disk quota for sandbox directories.
It is implemented as user disk quota or as porto (project) quota volume.
Root volume quota works independently but enforces the same limits.
It is implemented only for porto volume.