add debug tools to ytsaurus-odin docker image #449
Conversation
| @@ -2,6 +2,7 @@ python-dateutil==2.8.2 | |||
| Flask==2.0.3 | |||
| Werkzeug==2.2.2 | |||
| cheroot==10.0.0 | |||
| python-prctl==1.8.1 | |||
There was a problem hiding this comment.
Я вроде избавлялся от необходимости зависеть от prctl, она тут точно нужна?
Просто у этой библиотеки плохая лицензия
There was a problem hiding this comment.
как я понимаю, она же в Арке используется в завендоренном виде из контриба?
как я понимаю, она же в Арке используется в завендоренном виде из контриба?
There was a problem hiding this comment.
Sorry for Russian lang :(
I claim that Odin works correctly even without python-prctl
There was a problem hiding this comment.
IMHO without prcrl/pdeathsig odin easily leaks processes when something goes wrong.
There was a problem hiding this comment.
Maybe, but it should be checked and fixed in this case. Because prctl is under GPL and I prefer to avoid using this module even as dependency installed in Docker image.
There was a problem hiding this comment.
Maybe, but it should be checked and fixed in this case.
Can you elaborate, what do you mean here? Setting correct prctl is exactly the way of correct orphaned child reaping.
Because prctl is under GPL and I prefer to avoid using this module even as dependency installed in Docker image.
Why so? We do include GPL dependencies in our docker images, YTsaurus one depends on libiconv, for example. Having a binary distribution of GPL dependency in form of a Docker image dependency does not violate any form of GPL, as far as we researched in 2022.
There was a problem hiding this comment.
Can you elaborate, what do you mean here?
Sure, I mean slightly improve usages of prctl to avoid using this library. One way is writing small cython-bindings for setting pdeathsig (the simplest way I think), another way is to figure out cases in which processes can leak and fixing these cases.
Why so? We do include GPL dependencies in our docker images,
libiconv library distributed under LGPL license, it allows to use it as a dynamically linked dependency, but python-prctl distributed under GPL and as far as I know this license does not allow to use library even as a dependency.
No description provided.