Override ffmpeg scaling when 'source_resolution' detected in an outpu… #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| # Override Scaling filters if source resolution is set as tag | ||
| if "source_resolution" in output_def['tags']: | ||
| res_filters = [f for f in res_filters if "scale" not in f] | ||
|
|
ynbot
added
size/XS
BigRoy
reviewed
Mar 18, 2024
BigRoy
reviewed
Mar 18, 2024
Comment on lines
+718
to
+720
| # Override Scaling filters if source resolution is set as tag | ||
| if "source_resolution" in output_def['tags']: | ||
| res_filters = [f for f in res_filters if "scale" not in f] |
There was a problem hiding this comment.
Doesn't it make more sense to just skip the rescaling filters completely instead of 'filtering it out afterwards'?
There was a problem hiding this comment.
Hey thanks for checking, yes i don't see why not skipping all rescaling filters. Just wanted to remove the 'scale' one in our case.
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
| @@ -1226,6 +1232,11 @@ def rescaling_filters(self, temp_data, output_def, new_repre): | |||
| """ | |||
| filters = [] | |||
|
|
|||
| # Skip rescaling filters if "source_resolution" tag is present | |||
| if "source_resolution" in output_def['tags']: | |||
| self.log.debug("Source resolution tag present, skipping rescaling filters") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This is a simple change to override scaling filters for reviewables in ffmpeg if the 'source_resolution' tag is detected in the output definition.
This is an important feature for us as we tend to publish multiple resolutions from the same comp, as a single comp creates variants of the main comp to be delivered on each screen. We need an accurate reviewable on Ftrack based on the source resolution rather than the resolution settings of the comp or context of the task.
Testing notes:
This has been tested both using local publish and deadline submission. Only tested using an h264 profile.