Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: TyCache Family Enhancement #5930

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Nov 17, 2023

Changelog Description

This PR introduces several small enhancements on TyCache Family

  1. Code tweaks to support multiple export-particle operators with different names in both TyCache and TySpline Family.

  2. Supports the export mode of tyCache Splines (Split tycache families into two, one is tyCache and the other is tySplineCache)

  3. Optional Validator for frame range in both TyCache and TySpline Family
    image

  4. Add Loader with tySplineCache modifiers for tySpline Family

Additional info

Template path naming has changed so please ensure you have the updated settings with updated addons.
Check with the following project settingto see if it has the aligned settings with the screenshot below
Openpype:
project_settings/global/tools/publish/template_name_profiles
image

AYON:
Make sure your addons are at the right version.
Core: v0.1.5, Max: v0.1.4, Openpype: 3.17.7-nightly.7
And make sure you have the tycache template path set in Anatomy Presets
image

***This can be ready for review after the adjustment on the representation data.

Testing notes:

  1. Launch 3dsMax via launcher
  2. Create TyCache/TySpline Family with tyFlow object which has events and export-particle operators with different names
  3. Publish
  4. Make a new scene
  5. Load the cache back

@ynbot
Copy link
Contributor

ynbot commented Nov 17, 2023

Task linked: OP-7406 3dsmax: tyCache enhancements

@ynbot ynbot added host: 3dsmax Autodesk 3dsmax size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality labels Nov 17, 2023
@moonyuet moonyuet marked this pull request as ready for review November 20, 2023 07:33
@moonyuet moonyuet marked this pull request as draft December 13, 2023 08:35
@moonyuet moonyuet marked this pull request as ready for review December 13, 2023 15:29
@moonyuet
Copy link
Member Author

Will close the related PR #5901 on removing creating TyCache Object after this PR has been approved.

@mkolar mkolar added the sponsored Client endorsed or requested label Feb 9, 2024
@mkolar
Copy link
Member

mkolar commented Feb 9, 2024

@moonyuet we'll need AYON port before merging please

@moonyuet moonyuet marked this pull request as ready for review April 15, 2024 15:40
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a big PR - didn't go through it in too much detail since it's 3DsMax and TyFlow - two things I know close to nothing about. Just commented on stuff that stood out to me on a quick read. Likely best for someone from the Ynput team to go through in more detail instead.

I have a feeling that it's a bit overcomplicated for some reason, but I can't put my finger on it why I feel that way because maybe it's needed for what you're trying to do.

openpype/hosts/max/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/max/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/max/api/lib.py Outdated Show resolved Hide resolved
openpype/hosts/max/api/plugin.py Outdated Show resolved Hide resolved
openpype/hosts/max/api/plugin.py Outdated Show resolved Hide resolved
openpype/hosts/max/plugins/publish/collect_frame_range.py Outdated Show resolved Hide resolved
openpype/hosts/max/plugins/publish/collect_members.py Outdated Show resolved Hide resolved
openpype/hosts/max/plugins/publish/collect_members.py Outdated Show resolved Hide resolved
openpype/hosts/max/plugins/publish/collect_members.py Outdated Show resolved Hide resolved
@moonyuet
Copy link
Member Author

Quite a big PR - didn't go through it in too much detail since it's 3DsMax and TyFlow - two things I know close to nothing about. Just commented on stuff that stood out to me on a quick read. Likely best for someone from the Ynput team to go through in more detail instead.

I have a feeling that it's a bit overcomplicated for some reason, but I can't put my finger on it why I feel that way because maybe it's needed for what you're trying to do.

I can see your point.
I can't find the best way to get the multiple operators to be exported due to the limitation of tyflow API (maybe the 3dsmax api limitation too). I hope tyFlow API can eventually improve the API so that I dont need to implement some new stuff which is a bit over-engineered for the host to store the related data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: 3dsmax Autodesk 3dsmax port to AYON size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested target: AYON type: enhancement Enhancements to existing functionality
Projects
Status: Review In Progress
Development

Successfully merging this pull request may close these issues.

None yet

6 participants