Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: publishing improvements #5865

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Resolve: publishing improvements #5865

wants to merge 15 commits into from
+384 −65

Conversation

jakubjezek001
Copy link
Member

Changelog Description

Frame rate are now supported on multiple levels. Audio publishing is also supported.

Additional info

  • fixing frame rate distribution in otio exporter
  • improving otio exporter module docstrings
  • audio instances support

Testing notes:

  1. start with this step
  2. follow this step

@ynbot
Copy link
Contributor

ynbot commented Nov 3, 2023

Task linked: OP-7318 resolve: publishing issues

@ynbot ynbot added size/S Denotes a PR changes 100-499 lines, ignoring general files type: bug Something isn't working host: Resolve labels Nov 3, 2023
@jakubjezek001 jakubjezek001 changed the title Resolve: publishing Resolve: publishing fixes Nov 3, 2023
@jakubjezek001 jakubjezek001 changed the title Resolve: publishing fixes Resolve: publishing improvements Nov 3, 2023
@64qam
Copy link
Member

64qam commented Nov 5, 2023

For some reason, I am able to publish work files only. Creators do nothing in Resolve.

@tweak-wtf
Copy link
Collaborator

hey.. here i am 🙃

iLLiCiTiT
iLLiCiTiT reviewed Nov 13, 2023
View reviewed changes
openpype/plugins/publish/collect_otio_subset_resources.py
self.log.debug("timeline_fps: {}".format(timeline_fps))
self.log.debug("media_fps: {}".format(media_fps))
if (
instance.context.data["hostName"] == "resolve" and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this logic be here if is "resolve" specific? Considering we'll be splitting all the parts into addons this can cause huge issues in future.

@jakubjezek001
Copy link
Member Author

this might be also related to following PRs

#6126
#6128

@mkolar mkolar added port to AYON sponsored Client endorsed or requested labels Feb 8, 2024
@tokejepsen tokejepsen assigned jakubjezek001 and unassigned BigRoy Feb 13, 2024
@tokejepsen
Copy link
Member

Could we get some testing notes on this?

@tokejepsen tokejepsen marked this pull request as draft February 13, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT left review comments

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@BigRoy BigRoy Awaiting requested review from BigRoy

@64qam 64qam Awaiting requested review from 64qam

@mkolar mkolar Awaiting requested review from mkolar

At least 1 approving review is required to merge this pull request.

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Resolve port to AYON size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested target: AYON type: bug Something isn't working
Projects
PR reviewing
Status: Review In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jakubjezek001 @ynbot @64qam @tweak-wtf @tokejepsen @iLLiCiTiT @BigRoy @mkolar