Use GNUInstallDirs; Fix install location of CMake config files; include CMakeFindDependencyMacro module #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yixuan The PR does the following things:
GNUInstallDirs
. There are some reasonable variables that can be used to faciliate the installation in CMake, instead of the hard-coded path.${CMAKE_INSTALL_DATADIR}/cmake/Spectra
notshare/spectra/cmake
, in Linux as I know.include(CMakeFindDependencyMacro)
before usingfind_dependency
. https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html