Include Spectra as a subdirectory in a CMake build #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the separation of build-tree and install-tree explicit. This enables to retain the same installation functionality, while adding the functionality for including Spectra as a CMake subproject via add_subdirectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to include Spectra as a subdirectory project via the
add_subdirectorycall in CMake. For example, the following should add theSpectra::Spectratarget to the build tree so it can be linked to further down the line without the need for installation:assuming
spectrais in the directorythird-party/. This should enable Spectra to be utilized as a git submodule.Notes
The installation behaviour should have remained unchanged. I also added some stuff to the .gitignore.