-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Via joined #19805
Draft
rhertogh
wants to merge
21
commits into
yiisoft:master
Choose a base branch
from
rhertogh:via_joined
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Via joined #19805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several functions to the
\yii\db\ActiveQuery
class to support relations using 'inner join' to resolve the 'via' relation(s). This solves the problems described in the "fixed issues" list above and on the following websites:https://stackoverflow.com/questions/27690401
https://stackoverflow.com/questions/69329769
https://forum.yiiframework.com/t/how-to-orderby-on-viatable-in-hasmany-model-relationship/80043
https://copyprogramming.com/howto/can-t-sort-hasmany-relationship-in-yii2
The new functions are:
viaJoined()
: Same asvia()
but using inner join(s).viaJoinedTable()
: Same asviaTable()
but using inner join.viaJoinedTables()
: Supports multiple via tables using inner joins.ToDo: