-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pcntl_signal_dispatch after job finish for php extension #485
base: master
Are you sure you want to change the base?
Conversation
dimanzver
commented
Apr 27, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | add pcntl_signal_dispatch after job finish for php extension |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use-case?
@@ -1,5 +1,5 @@ | |||
{ | |||
"name": "yiisoft/yii2-queue", | |||
"name": "dimanzver/yii2-queue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "dimanzver/yii2-queue", | |
"name": "yiisoft/yii2-queue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For handling of stopsignal in docker container. For example, in Kubernetes on deploy
src/drivers/amqp_interop/Queue.php
Outdated
@@ -305,6 +305,10 @@ public function listen() | |||
|
|||
$this->redeliver($message); | |||
|
|||
if (function_exists('pcntl_signal_dispatch') && $consumer instanceof \Enqueue\AmqpExt\AmqpConsumer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why \Enqueue\AmqpExt\AmqpConsumer
?
We have interop driver - Interop\Amqp\AmqpConsumer
.
Look now - I reworked logic |
No need to change the package name |