Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction support #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Transaction support #276

wants to merge 1 commit into from

Conversation

Lisio
Copy link

@Lisio Lisio commented May 25, 2019

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? n/a
Fixed issues

@Lisio Lisio marked this pull request as ready for review May 25, 2019 00:08
@Lisio
Copy link
Author

Lisio commented May 25, 2019

Something wrong with the tests, current master also fails.

@samdark samdark added status:code review The pull request needs review. type:enhancement Enhancement pr:request for unit tests Unit tests are needed. and removed status:code review The pull request needs review. labels May 28, 2019
@yii-bot
Copy link

yii-bot commented May 28, 2019

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

@Lisio
Copy link
Author

Lisio commented Jan 12, 2020

Do we need to use version 1.1.8 of mongodb extension for php 5.5? Session parameter is only compatible with 1.4.0 which is compatible with php 5.5.

@samdark
Copy link
Member

samdark commented Jan 16, 2020

No, we don't. Likely using precise as OS would help. Let's check it...

@samdark
Copy link
Member

samdark commented Jan 16, 2020

But first, let's merge master into this branch...

@samdark
Copy link
Member

samdark commented Mar 4, 2020

@Lisio tests seems to fail on 5.4.

@Lisio
Copy link
Author

Lisio commented Mar 4, 2020

Testing environment fails to install correct version of mongodb library

configure: error: not supported. Need a PHP version >= 5.6.0 (found 5.4.45)
ERROR: `/tmp/pear/install/mongodb/configure --with-php-config=/home/travis/.phpenv/versions/5.4/bin/php-config' failed
MongoDB PHP Extension version:
MongoDB support => enabled
MongoDB extension version => 1.2.6

@samdark
Copy link
Member

samdark commented Mar 4, 2020

@samdark samdark added this to the 2.1.10 milestone Mar 12, 2020
@samdark samdark removed the pr:request for unit tests Unit tests are needed. label Mar 12, 2020
@samdark samdark modified the milestones: 2.1.10, 2.1.11 Nov 10, 2020
@samdark samdark modified the milestones: 2.1.11, 2.1.12 Dec 23, 2020
@samdark samdark removed this from the 2.1.12 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants