Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling: ensure background gradient always fills page #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kwvg
Copy link

@kwvg kwvg commented Nov 16, 2021

Expected Behavior

image

Actual Behavior

image

Proposed Fix

Basically the implementation of @amitkhare's comment from StackOverflow on a question about the same subject

Copy link
Owner

@ygoex ygoex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kittywhiskers. Thank you for creating the pull request.

After a little bit of testing I've seen that the issue addressed only happens on screens over ~1400px.

Given the previous and that the background works as designed for small and medium screen devices, the best solution would be to create a new breakpoint right under the existing background-size: contain; in _common.scss, _home-tmpl.scss and _dark-theme.scss with the following snippet:

    @include media-query(xxl) {
      background-size: cover;
    }

No prefixes are required, since this is something that the PostCSS Autoprefixer plugin does when the production build runs (npm run build).

Also, for the previous snippet to work, it will also be required to create a new breakpoint under _settings.scss. The following comment needs to be added in line 15: /// 90rem * 16px = 1440px;, and the breakpoint itself included in line 22: "xxl": 90em. The breakpoint xl will require a comma at the end of the line.

Please let me know if there is something that needs further clarification.

@kwvg
Copy link
Author

kwvg commented Dec 21, 2021

Sorry for the delay! I can't say I know a thing about SCSS but hopefully my updated commit reflects your description as best as possible.

Thanks for your help!

@kwvg kwvg requested a review from ygoex December 21, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants