This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Ignore extra characters at filename end in search #302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with certain bower assets (esp. webfonts). CSS paths may include extra characters intended to promote wide cross-browser compatibility and may not relate to the actual file on the file system. e.g.
In this case, the file name
../fonts/ionicons.eot?v=1.4.1
contains the suffix?v=1.4.1
. The actual file the revved finder needs to find isionicons.eot
. When the revvedfinder runspath.extname
andpath.basename
on this file name. The extname is assigned.1
and the basename is assignedionicons.eot?v=1.4
. The file is not found, and not replaced in usemin. Eventually causing builds to contain incorrectly referenced font paths.This PR will preprocess the filename to remove these characters so that revvedfinder can find the file.
Relevant: yeoman/yeoman#824 (comment)