This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Add basename option #60

Open

stephanebachelier wants to merge 3 commits into yeoman:master from stephanebachelier:basename-option

Contributor

stephanebachelier commented Oct 27, 2014

Should fix #15 with a different approach from PR #44
Should also help #53 as it will easier to handle by other grunt tasks, as no path will be added.

As a side note, you will see in 60c53f2 that I needed to specify each tests with filerev:xxx as I need to manipulate the grunt.filerev.summary.

/CC @sindresorhus

stephanebachelier added 3 commits

October 27, 2014 03:58


          feat(basename): add option for output basename only

cc995cb

Conflicts:
	tasks/filerev.js


          test(basename): add test for basename

74387df


          doc(README): add documentation about basename option

b732344

stephanebachelier force-pushed the basename-option branch from 0b201dc to b732344 Compare

October 27, 2014 02:58

madrobot commented Nov 14, 2014

Please merge, this is a much needed option!

Member

sindresorhus commented Nov 16, 2014

I don't think this solves the problem in the right way. The option should be named base and you should be able to supply a string with a path the is the base and the resulting paths will be relative to this one.

Contributor Author

stephanebachelier commented Nov 21, 2014

@sindresorhus make sense :) I update the PR.

Member

arthurvr commented Jun 7, 2015

ping @stephanebachelier - This PR needs some updates, as well as a rebase.

Contributor Author

stephanebachelier commented Jun 30, 2015

@arthurvr waiting for the decision about the rewrite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.