Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1242] fix diamond operator false positive warning #1243

Merged
merged 2 commits into from Mar 27, 2024

Conversation

pnatashap
Copy link
Contributor

@pnatashap pnatashap commented Mar 27, 2024

  • disable PMD.UseDiamondOperator
  • one more exception for DiamondOperatorCheck

Fix #1242

@pnatashap
Copy link
Contributor Author

@yegor256 please take a look

@yegor256
Copy link
Owner

@rultor merge

@yegor256
Copy link
Owner

@rultor status

@rultor
Copy link
Collaborator

rultor commented Mar 27, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Mar 27, 2024

@rultor status

@yegor256 This is what's going on here:

  • request 2021850064 is in processing, command is merge
  • request has 6 parameter(s):
  • fork: git@github.com:pnatashap/qulice.git
  • fork_branch: 1242
  • head: git@github.com:yegor256/qulice.git
  • head_branch: master
  • pull_id: 1243
  • pull_title: [#1242] fix diamond operator false positive warning
  • build is not running

More information about Rultor commands you can get here.

@rultor rultor merged commit 03b211b into yegor256:master Mar 27, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Mar 27, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@pnatashap pnatashap deleted the 1242 branch March 27, 2024 04:03
@yegor256
Copy link
Owner

@pnatashap thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diamond operator check gives false positive
3 participants