Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1198] update pmd and checkstyle, fix saxon #1202

Merged
merged 3 commits into from Mar 11, 2024
Merged

Conversation

pnatashap
Copy link
Contributor

@pnatashap
Copy link
Contributor Author

pnatashap commented Mar 11, 2024

@yegor256 please take a look
this version works for rultor, but still throw java.lang.IllegalArgumentException for cactoos. Works good if update pmd-core to 6.55.0.

Copy link
Owner

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's polish a bit and it's ready to merge

@@ -87,6 +103,7 @@ private void report(final int current, final int end) {
final int diff = current - end;
if (diff > 1) {
for (int pos = 1; pos < diff; pos += 1) {
System.out.printf("report=%d\n", end + pos);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnatashap let's get rid of this

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 11, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8d11ec6 into yegor256:master Mar 11, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Mar 11, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants