Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented test for irca feature #280

Merged
merged 14 commits into from Apr 17, 2024
Merged

Conversation

zaqbez39me
Copy link
Contributor

Test for Impact Ratio by Commit Authors (IRCA) in #226

@zaqbez39me zaqbez39me changed the title Implemented test for ir feature Implemented test for irca feature Apr 15, 2024
@zaqbez39me
Copy link
Contributor Author

@yegor256 please, check this test out

@yegor256
Copy link
Owner

@zaqbez39me looks good, but make fails (see above). Also, to disable a test, it's better to do exit 0 at the beginning of the script, instead of commenting it all out

@zaqbez39me
Copy link
Contributor Author

@yegor256 fixed the test disabling method. Please, check my reasoning about make in #259

@zaqbez39me
Copy link
Contributor Author

@yegor256 after providing access for execution for test-irca.sh and adding the stub irca.sh, I met with another error that is not directly connected with my part. Maybe, this error in pipline was before in master branch

@yegor256
Copy link
Owner

@zaqbez39me the master branch has a clean build: https://github.com/yegor256/cam/actions/workflows/make.yml

@zaqbez39me
Copy link
Contributor Author

@yegor256 as I see this error occurs because of my stub and test-measure-file.sh conflict. If I make my stub return "IRCA 0.000" then the test-measure-file.sh fails with the error 'Exactly 52 metrics were expected, but 53 were actually collected' because of hardcoded 52 constant in it.

@zaqbez39me
Copy link
Contributor Author

I had to add stub because of another test that checks following:
If test exists then the script also must exist

@yegor256
Copy link
Owner

@zaqbez39me maybe you should change the number in the test-measure-file.sh?

@zaqbez39me
Copy link
Contributor Author

@yegor256 maybe, I should better fix the hardcoded value with calculated in separate pull request and then rerun all the pipelines again?

@yegor256
Copy link
Owner

@zaqbez39me sounds good!

@zaqbez39me
Copy link
Contributor Author

@yegor256 please, check it out. Now everything works fine

@yegor256 yegor256 merged commit 029f6a6 into yegor256:master Apr 17, 2024
8 checks passed
@yegor256
Copy link
Owner

@zaqbez39me thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants