New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install reqired tlmgr
in install script if necessary
#215
Conversation
steps/install.sh
Outdated
echo "Install 'parallel' somehow" | ||
exit 1 | ||
install_or_quit() { | ||
if ! dpkg -s "$1" >/dev/null 2>&1; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howcanunot there is no dpkg
in MacOS :)
steps/install.sh
Outdated
exit 1 | ||
fi | ||
fi | ||
install_or_quit 'python3-pygments' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howcanunot there is no python3-pygments
in MacOS when pygmentize
is installed
steps/install.sh
Outdated
install_or_quit 'aspell' | ||
install_or_quit 'xmlstarlet' | ||
|
||
if [ ! -f "/usr/local/texlive/$(date +%Y)/bin/x86_64-linux/tlmgr" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howcanunot how about MacOS?
@howcanunot appreciate your contribution! Please, try to run |
@yegor256 good evening! improved the script to satisfy the multiplatform condition. |
steps/install.sh
Outdated
fi | ||
fi | ||
TEXLIVE_DIR=$(ls -d /usr/local/texlive/"$(date +%Y)"/bin/*/) | ||
PATH="$PATH:$TEXLIVE_DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howcanunot I believe, it should be export PATH=...
Otherwise, the changes you make will only be visible inside this script. Is is what you intend to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howcanunot I still think that it's wrongly placed. What if texlive
is already installed on my machine? You still want to modify my PATH
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 well, it won't be worse
but in general it's more logical to put the PATH
inside the if.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@yegor256 Can you please help with debugging the bibcop check? I'm not sure I understand how to fix it... Or i just should wait for the fix and then pull. |
@howcanunot thanks! |
tlmgr
is part of texlive package. We don't really want to install the full package, so if the utility was not installed before running the script, we try to install it with minimal dependencies, since installing the whole package can take a lot of time and about 6 GB of disk spaceAlso a bit of code refactoring to remove unnecessary copy-paste
#174