(#1704) Implement a Multiline Text #1706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnatashap
reviewed
Jan 17, 2024
| new Joined( | ||
| " ", | ||
| "The quick brown fox jumps over the lazy", | ||
| "black dog and after that returned to " |
There was a problem hiding this comment.
If I can still calculate correctly, the string 'The quick brown fox jumps over the lazy black dog and after that returned to the' is exactly 80 symbols which is the default value, so looks like expected value is wrong.
The problem is in size variable during calculation, you always add SPACE
|
@pnatashap Can you take another look, please? |
|
Now it works fine, several points that it is not easy to understand (just my point of view):
|
|
@yegor256 @victornoel please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a Multiline Text.