Forward GeoInterface.centroid #365
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
commented
Jan 19, 2023
|
This is already tested as working. But yes we also need to handle features somehow. I guess I should have handle that in GeoInterface as well. |
Noticed that this was missing, so decided to correct it.
asinghvi17
force-pushed
the
as/more_geointerface
branch
from
248236c
to
1ab5bfa
Compare
asinghvi17
changed the title
GeoInterface.convert(ArchGDAL, obj) to "just work"
|
A test ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work for FeatureCollections yet, and no tests have been added. It's essentially a quick and dirty implementation where I extended the type constraints on the mainGeoInterface.convertmethod and implementedArchGDAL.geointerface_geomtype(arg) = IGeometry. Since it operates on traits, it seemed a fair bet, and any feature-like object can of course be overloaded.Changed the PR to just forward GeoInterface.centroid, which seemed to be missing.