YQL-18052: Introduce CLI option to purebench to toggle block engine mode #4526
Conversation
|
⚪ |
|
⚪ |
|
⚪ |
igormunkin
force-pushed
the
YQL-18052-add-block-engine-to-purebench
branch
from
d8894df
to
ed45800
Compare
|
⚪
|
|
⚪
|
igormunkin
force-pushed
the
YQL-18052-add-block-engine-to-purebench
branch
from
ed45800
to
1db9939
Compare
|
⚪
|
|
⚪
|
As a result of the patch, the body of the thrown TCompileError is also yield to stderr.
This patch implements passing through the block engine mode, being set in the program factory, to the worker type context.
This patch introduces BlockEngineSettings option for program factory to tweak the block engine mode. The possible values are "force" to unconditionally enable it, "disable" for turn it off and "auto" to left the final decision to the platform heuristics.
This patch implements conversion from the string option set via the purecalc interface to the corresponding enum value. If the conversion fails, TCompileError is raised. Unfortunately, there is no way to hoist the conversion upper in the call stack, since this will lead to exposure of the private interfaces.
This patch introduces the purebench CLI option to tweak the mode of the block engine while performing the benchmarks.
igormunkin
force-pushed
the
YQL-18052-add-block-engine-to-purebench
branch
from
1db9939
to
222bef4
Compare
|
⚪
|
|
⚪ |
|
⚪
|
igormunkin
changed the title
This patchset introduces CLI option (
-b/--block-engine) topurebenchfor toggling block engine mode. It is initially set as a string value (one from'force','disable'and'auto'), and converted toEBlockEngineModein program factory constructor. If the conversion fails,TCompileErroris raised.There was also a tiny bug: the
TCompileErrorerror body was not printed. As a result of the first patch of the series this issue is fixed.Changelog category