Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing <functional> include #4493

Merged
merged 1 commit into from
May 15, 2024
Merged

Add missing <functional> include #4493

merged 1 commit into from
May 15, 2024

Conversation

4JustMe4
Copy link
Collaborator

Changelog entry

Avoid this type of errors on upcoming protobuf update since some transitive includes have been removed.

$(SOURCE_ROOT)/contrib/ydb/library/yql/minikql/dom/convert.h:327:26: error: implicit instantiation of undefined template 'std::function<NYql::NUdf::TUnboxedValuePod (NYql::NUdf::TUnboxedValuePod)>'
        const TConverter Converter;
                         ^
$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/stlfwd:46:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS function;

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@4JustMe4 4JustMe4 requested a review from a team as a code owner May 14, 2024 10:09
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

⚪ 2024-05-14 10:10:41 UTC Pre-commit check for 60217bb has started.
⚪ 2024-05-14 10:10:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-14 10:13:19 UTC Build successful.
⚪ 2024-05-14 10:14:58 UTC Tests are running...
🔴 2024-05-14 12:02:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14058 13959 0 35 55 9

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

⚪ 2024-05-14 10:11:25 UTC Pre-commit check for 60217bb has started.
⚪ 2024-05-14 10:11:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-14 10:14:51 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

⚪ 2024-05-14 10:13:43 UTC Pre-commit check for 60217bb has started.
⚪ 2024-05-14 10:13:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-14 10:16:54 UTC Build successful.
⚪ 2024-05-14 10:18:39 UTC Tests are running...
🔴 2024-05-14 12:14:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72887 59691 0 2 13188 6

@maximyurchuk maximyurchuk merged commit 7156a4e into ydb-platform:main May 15, 2024
4 of 6 checks passed
naspirato pushed a commit to naspirato/ydb that referenced this pull request May 15, 2024
@4JustMe4 @naspirato
Add missing <functional> include (ydb-platform#4493)
83c841b
@GrigoriyPA GrigoriyPA mentioned this pull request May 16, 2024
Closed
This was referenced May 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Open
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@4JustMe4 @MrLolthe1st
Add missing <functional> include (ydb-platform#4493)
589a348
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4JustMe4 @maximyurchuk @zverevgeny