Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ruby to 3.2 before end of normal maintenance #1581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nanophate
Copy link
Member

やりたいこと

ruby 3.1 のノーマルメンテナンス終了が大体リリースから 3 年なので、例年通りであれば、2024-04-1 メンテナンス終了と思うので、ruby 3.2 に上げたい

Ruby 3.2
ステータス: normal maintenance
リリース: 2022-12-25
ノーマルメンテナンス終了: TBD
EOL: 2026-03-31(見込み)

Ruby 3.1
ステータス: normal maintenance
リリース: 2021-12-25
ノーマルメンテナンス終了: TBD
EOL: 2025-03-31(見込み)

Ruby 3.0
ステータス: security maintenance
リリース: 2020-12-25
ノーマルメンテナンス終了: 2023-04-01
EOL: 2024-03-31(見込み)
https://www.ruby-lang.org/ja/downloads/branches

@yasulab
Copy link
Member

yasulab commented Feb 12, 2024

Ruby 3.2+ になったら YJIT 有効化でパフォーマンスが向上するかも...!?!? 😆✨

cf. Ruby 3.3でYJITを今すぐ有効にすべき理由
https://k0kubun.hatenablog.com/entry/ruby-3-3-yjit

@nanophate
Copy link
Member Author

CI が下記で落ちてました。FYI: html-proofer のバージョンを 5.0.0 から 5.0.8 にアップデートしたら直りました。

Caused by:
ArgumentError: wrong number of arguments (given 4, expected 3)
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/async-2.1.0/lib/async/scheduler.rb:164:in `io_read'
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/html-proofer-5.0.0/lib/html_proofer/utils.rb:17:in `read'
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/html-proofer-5.0.0/lib/html_proofer/utils.rb:17:in `create_nokogiri'
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/html-proofer-5.0.0/lib/html_proofer/runner.rb:114:in `load_file'
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/html-proofer-5.0.0/lib/html_proofer/runner.rb:106:in `block (3 levels) in process_files'
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/async-2.1.0/lib/async/task.rb:107:in `block in run'
/home/runner/work/railsguides.jp/railsguides.jp/vendor/bundle/ruby/3.2.0/gems/async-2.1.0/lib/async/task.rb:243:in `block in schedule'

Copy link

@rakuda-san-desu rakuda-san-desu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます!
良さそうです🙆‍♀️

rbenv local 3.2.3 の後 bundle install を問題なく実行でき、差分も出ませんでした。

@nanophate
Copy link
Member Author

@rakuda-san-desu 早速の確認ありがとうございます!

@yasulab
Copy link
Member

yasulab commented Feb 24, 2024

こちらご都合の良いタイミングでマージしていただければ...!! (>人< )✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants