Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made progress dialog a multipurpose dialog that supports both indefinite and horizontal progress bar. #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blakelee
Copy link

@blakelee blakelee commented Jul 8, 2017

screenshot_1499549049
The following methods for LovelyProgressDialog have been added:

setHorizontal(boolean)
setMax(int)
setProgressObservable(LovelyProgressObservable)
closeOnComplete(boolean)

By default closeOnComplete is true

The sample has been updated to reflect these changes. You'll notice there is some thread trickery going on.

I have also updated some of the dependencies that were suggested by thedude61636.

This is my first pull request :) so I'm open to suggestions on how to make it cleaner.

@blakelee
Copy link
Author

blakelee commented Jul 8, 2017

Android Studio terminal is actually aids. Will re-add once I can get the changes merged into one commit.

@blakelee blakelee reopened this Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant