Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream unencrypted headers #466

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

michaelkirk-signal
Copy link

@michaelkirk-signal michaelkirk-signal commented Aug 1, 2018

Ok this is ready for review.

This builds on top of #439

  • Adds more documentation
  • Adds some sanity checking asserts to make sure you're specifying either:
    • a key-spec
    • a key+salt.
  • simplifies the migration utils to only require a recordSalt callback (and tries to make it clearer what that callback should do).

Using a key spec allows you to skip expensive key derivation which occurs every time you create a new DB connection.

Since we're generating random key data, as opposed to having the user specify a passphrase, there's no reason not to just generate a key-spec length key and skip derivation.

FWIW - We've been using this in production for about 9 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants