Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus-in & focus-out support #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rickpern
Copy link

I wanted to be able to add focus-in and focus-out actions like you can do on the input and textarea helpers.

examples:

 {{#labeled-radio-button value=value groupValue=groupValue focus-in='onFocus' focus-out='onBlur'}}{{label}}{{/labeled-radio-button}}
 {{radio-button value=value groupValue=groupValue focus-in='onFocus' focus-out='onBlur'}}

@raycohen
Copy link
Contributor

this looks pretty good. do you think you could add a test for it?

@rickpern
Copy link
Author

@raycohen yeah, i can try to do it this week...traveling a bit, so i'll do my best. also the tests aren't failing b/c of my commits, i reverted and they still fail just FYI.

@raycohen
Copy link
Contributor

Thanks. We run the tests against multiple versions of ember and they've been failing for a while on newer versions.

If you do get around to adding a test, I'll merge it as long as it passes against 1.11 and 1.12 (Which this PR currently does pass against)

@rickpern
Copy link
Author

rickpern commented Dec 7, 2015

@raycohen i still plan on writing those tests. about to actually add some more properties to this, so i'll try to do it then.

@raycohen
Copy link
Contributor

raycohen commented Dec 7, 2015

@rickpern great! I've been a little distracted but I am interested in merging this work, so let me know how I can help

@raycohen
Copy link
Contributor

raycohen commented Jan 4, 2016

@rickpern master is updated to use ember-cli 1.13.13, and tests are passing on all ember versions. Can you rebase this?

},

focusIn() {
Ember.run.once(this, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using an anonymous function here defeats the purpose of using run.once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants