Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support close on mouseleave for tether dialog #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BrianSipple
Copy link

@BrianSipple BrianSipple commented May 23, 2016

Hello,

Thanks for putting together a super-useful addon that tackles a really hard problem.

I recently had a tether-dialog modal that I wanted to have close on mouseleave events, so that it would behave as a hoverable “pop-out” modal — much like the one seen here in Google Keep.

After implementing this successfully in a local fork, I figured I'd PR it back and propose a few additions to the tether-dialog component. modal-dialog itself already has closeOnClick, and the implementation here follows a very similar pattern (though I localized the functionality to tether-dialog because that seems to be the only pattern where it would make sense).

I also added a dummy app example for the behavior and some corresponding acceptance tests. (As a bit of an aside, I couldn’t help but notice that some of the patterns in the dummy app’s application controller were a bit WET, so I felt somewhat awkward about adding to them. That said, I didn’t want to change the overall architecture as part of this PR, but would definitely be interested in subsequent contributions to do so 😄).

@BrianSipple BrianSipple changed the title Support close on mouseout for tether dialog Support close on mouseleave for tether dialog May 23, 2016
@lukemelia
Copy link
Contributor

@BrianSipple Thanks for contributing this back. Seems like there are some failures on more recent versions of Ember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants