Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to work with version 3.3.4 of Bosch driver #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kumekay
Copy link

@kumekay kumekay commented Apr 18, 2018

Probably I shouldn't make pull request, because this updated code doesn't work perfectly - it works as expected only with very low i2c clock speeds, like 40000.
If master_clk is ~ 100000 only pressure and humidity are sent by sensor,
if master_clk is 400000 or more - only humidity is sent (as non zero value).
I spent some time, but didn't find root of this issue, but it would be great, if you can help. Expect of this problem this commit fully supports lastest Bosch driver (v3.3.4)

@meltdown03
Copy link

I got the your Pull #2 to work with the latest Bosch drivers (Master Branch as of today) by changing the I2C speed to 100000 from 40000. I also changed the return type of the BME280_I2C_bus_write function to the correct uint8_t type. I'm even running it on the Master Branch of ESP-IDF using a ESP32-S2-Saola-1R board. I'm using it in the Smart Outlet example and uploading the data instead of using the examples random Temperature data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants