Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.0-alpha.0] Publishing ES and CJS #218

Merged
merged 27 commits into from
Mar 28, 2019
Merged

[3.0.0-alpha.0] Publishing ES and CJS #218

merged 27 commits into from
Mar 28, 2019

Conversation

roderickhsiao
Copy link
Collaborator

@roderickhsiao roderickhsiao commented Jan 24, 2019

Summery

This is the first 3.0.0 alpha PR, tracked in a master issue #224

This PR change to es syntax and publish both cjs and es module.

Enhancement:

  • Modernize package, publishing ES module and CJS

Breaking Changes

  • Drop mixin usage
  • Drop deprecated props followLink
  • Remove Node 6 support

@kaesonho @redonkulus How do you think?

Put out the WIP PR to get some early feedback, also if I can get some help will be lovely.

@kaesonho
Copy link
Contributor

kaesonho commented Mar 5, 2019

Thank you for updating this! ❤️

I personally feel it makes sense to make breaking changes then bump major version.
May I know the scope for this PR? When you get you unblocked I can also help updating these.

React.lazy and intersection observer actually look higher priority to me as they are actual perf improvement!

@roderickhsiao
Copy link
Collaborator Author

@kaesonho I think you are the person who knows the viewport and lifecycle/context use case :) I could do most of the build/es module part, and will be good if you could help for the places you are most familiar to.

I think we could seclude several alpha release so people could test out and slowing moving to the direction we want.

@roderickhsiao
Copy link
Collaborator Author

Will work on this PR again cause its preventing user to use the new context API cause react can only use one type of context api now.

Discussed with Kaeson, we will probably do small alpha release for each features so we won't be blocked by the whole list.

@roderickhsiao
Copy link
Collaborator Author

Issue for multiple context: facebook/react#14005

@roderickhsiao roderickhsiao changed the title [WIP] React i13n 3.0.0 Publishing ES and CJS Mar 26, 2019
@roderickhsiao
Copy link
Collaborator Author

Split into separate small PRs

@kaesonho
Copy link
Contributor

LGTM! 💯 🎆 thank you for making this change!

@roderickhsiao
Copy link
Collaborator Author

@redonkulus Do you think the approach of progressively release small version make sense to you?
Do you have anything you wish to put in 3.0.0 so we can work on it in the same time? (I'm trying to coordinate with @kaesonho and @antonychan to see if we can move this forward).

@redonkulus
Copy link
Contributor

@roderickhsiao I'm fine with this approach, makes more sense to do a series of small PR's, instead of one massive one.

@@ -1,279 +1,303 @@
// jscs:disable maximumLineLength
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd get rid of Grunt entirely in another PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@roderickhsiao
Copy link
Collaborator Author

roderickhsiao commented Mar 27, 2019

Release Log

  • Version: 3.0.0-alpha.0

Enhancement

  • We are now exporting cjs and es build

Breaking changes

  • Remove support for mixin
  • Remove deprecated props followLink
  • Drop Node 6 supports

Build

  • Use babel-present-env instead of preset 2015
  • Eslint integration
  • use nyc instead of Istanbul for test code instrumentation

@roderickhsiao roderickhsiao self-assigned this Mar 27, 2019
@roderickhsiao roderickhsiao changed the title Publishing ES and CJS [3.0.0-alpha.0] Publishing ES and CJS Mar 28, 2019
@roderickhsiao roderickhsiao merged commit 725f520 into yahoo:master Mar 28, 2019
@roderickhsiao roderickhsiao mentioned this pull request Apr 8, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants