Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interaction observer to detect viewport #182

Open
roderickhsiao opened this issue Oct 17, 2017 · 2 comments
Open

Use interaction observer to detect viewport #182

roderickhsiao opened this issue Oct 17, 2017 · 2 comments

Comments

@roderickhsiao
Copy link
Collaborator

roderickhsiao commented Oct 17, 2017

We could probably try to integrate intersection observer and fallback to the original logic if the browser doesnt support it.

https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

Also there is issue that currently the scroll event is attached on window, so it might cause issue if the we are using overflow scroll

Support
https://caniuse.com/#feat=intersectionobserver

How do you think?

@kaesonho
Copy link
Contributor

kaesonho commented Mar 5, 2019

👍 makes totally sense to me, maybe just use polyfill to make make the logic even simpler?

@roderickhsiao
Copy link
Collaborator Author

sure, but I'm not pretty familiar with the logic and I dont have a working app using the viewport function. Do you think the functional test/unit test cover this case?

@roderickhsiao roderickhsiao mentioned this issue Mar 25, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants