[Fixes #108] Refactor CRUD interface #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ```js | ||
| var Fetcher = require('fetchr'); | ||
| var fetcher = new Fetcher({ | ||
| xhrPath: '/myCustomAPIEndpoint' |
There was a problem hiding this comment.
You're right, fixing.
Closed
| @@ -41,7 +29,7 @@ function parseResponse(response) { | |||
| try { | |||
| return JSON.parse(response.responseText); | |||
| } catch (e) { | |||
| debug('json parse failed:' + e, 'error', NAME); | |||
| debug('json parse failed:' + e, 'error'); | |||
There was a problem hiding this comment.
It was just the string FetcherClient but debug automatically annotates so it was unnecessary.
|
@redonkulus updated. |
| * Add params to this fetcher request | ||
| * @method params | ||
| * @memberof Request | ||
| * @param {Object} params Information carried in query and matrix parameters in typical REST API |
|
Looks good, just come additional minor docblock comments. I'd like to see this applied internally to ensure we did not introduce any breaking changes before we publish. |
|
@redonkulus I tested this internally, and found no breaking changes. @mridgway can you give this a once over just so we have more than one person reviewing this PR? |
|
lgtm. This should be a new minor version since it introduces new warnings for deprecated APIs. |
|
👍 |
Vijar
added a commit
that referenced
this pull request
Aug 7, 2015
[Fixes #108] Refactor CRUD interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@redonkulus @mridgway @lingyan
Sorry this is so huge, one thing led to another down the rabbit hole. This PR includes:
registerFetcherandgetFetcherconstructGetUrifunction wasn't falling back properly