Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql-java from 6 to 16.2 #3044

Open
wants to merge 3 commits into
base: elide-4.x
Choose a base branch
from
Open

Upgrade graphql-java from 6 to 16.2 #3044

wants to merge 3 commits into from

Conversation

wcekan
Copy link
Contributor

@wcekan wcekan commented Aug 12, 2023

Description

Major upgrade of GraphQL Java backported to 4.x
Cherry picked from 5.0.5 PR #2228 with merge conflicts fixed.

Motivation and Context

GraphQL 6 is too old. This will be the first step in getting Elide 4.x to a more recent version of GraphQL.

How Has This Been Tested?

Unit testing. Local testing.

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@wcekan wcekan requested a review from aklish August 12, 2023 19:17
@wcekan
Copy link
Contributor Author

wcekan commented Aug 12, 2023

@aklish any idea about these 2 failures?

Failures:
FetcherFetchTest.testFetchWithFragments:166->runComparisonTest:208->PersistentResourceFetcherTest.runComparisonTest:285->PersistentResourceFetcherTest.runComparisonTest:302->PersistentResourceFetcherTest.assertQueryEquals:192->PersistentResourceFetcherTest.assertQueryEquals:218 author.edges[0].__typename
Expected: _edges__author
got: AuthorEdge
; author.edges[1].__typename
Expected: _edges__author
got: AuthorEdge

ModelBuilderTest.testBuild:143 authorInput ==> expected: not <null>

@wcekan wcekan requested a review from moizarafat August 12, 2023 20:00
@moizarafat
Copy link
Collaborator

Overall the changes looked good to me when compared to the original PR.

The test case testFetchWithFragments which is failing in FetcherFetchTest was removed as part of the below commit and replaced with different test cases though i can not remember why.

9bda018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants