Minor code tweaks.

yahoo · Jan 24, 2018 · c7f0126 · c7f0126
1 parent f8a1fd4
commit c7f0126
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/elide-core/src/main/java/com/yahoo/elide/core/RequestScope.java b/elide-core/src/main/java/com/yahoo/elide/core/RequestScope.java
@@ -75,8 +75,8 @@ public class RequestScope implements com.yahoo.elide.security.RequestScope {
     @Getter private final boolean useFilterExpressions;
     @Getter private final int updateStatusCode;
     @Getter private final boolean mutatingMultipleEntities;
-    @Getter @Setter private String historicalVersion = null;
-    @Getter @Setter private String historicalDate = null;
+    @Getter @Setter private Long historicalRevision = null;
+    @Getter @Setter private Long historicalDatestamp = null;
 
     @Getter private final MultipleFilterDialect filterDialect;
     private final Map<String, FilterExpression> expressionsByType;

diff --git a/elide-graphql/pom.xml b/elide-graphql/pom.xml
@@ -42,6 +42,12 @@
     </scm>
 
     <dependencies>
+        <!-- TODO: Refactor to remove this dep from graphql -->
+        <dependency>
+            <groupId>org.hibernate</groupId>
+            <artifactId>hibernate-envers</artifactId>
+            <version>5.0.2.Final</version>
+        </dependency>
         <dependency>
             <groupId>com.yahoo.elide</groupId>
             <artifactId>elide-core</artifactId>

diff --git a/elide-graphql/src/main/java/com/yahoo/elide/graphql/ModelBuilder.java b/elide-graphql/src/main/java/com/yahoo/elide/graphql/ModelBuilder.java
@@ -201,6 +201,7 @@ public GraphQLSchema build() {
 
         root.field(newFieldDefinition()
                         .name("__history")
+                        .dataFetcher(dataFetcher)
                         .argument(newArgument()
                                 .name("revision")
                                 .type(new GraphQLList(Scalars.GraphQLLong))

diff --git a/elide-graphql/src/main/java/com/yahoo/elide/graphql/containers/HistoryContainer.java b/elide-graphql/src/main/java/com/yahoo/elide/graphql/containers/HistoryContainer.java
@@ -7,6 +7,7 @@
 
 import com.yahoo.elide.graphql.Environment;
 
+import java.util.List;
 import java.util.Map;
 
 public class HistoryContainer extends RootContainer {
@@ -22,8 +23,8 @@ public class HistoryContainer extends RootContainer {
     HistoryContainer(Environment context) {
         Map<String, Object> args = context.arguments;
         if (args != null) {
-            context.requestScope.setHistoricalDate((String) args.get(DATE_KEY));
-            context.requestScope.setHistoricalVersion((String) args.get(REVISION_KEY));
+            context.requestScope.setHistoricalDatestamp((Long) ((List) args.get(DATE_KEY)).get(0));
+            context.requestScope.setHistoricalRevision((Long) ((List) args.get(REVISION_KEY)).get(0));
         }
     }
 }
diff --git a/elide-graphql/src/main/java/com/yahoo/elide/graphql/containers/RootContainer.java b/elide-graphql/src/main/java/com/yahoo/elide/graphql/containers/RootContainer.java
@@ -21,6 +21,11 @@ public class RootContainer implements GraphQLContainer {
     public Object processFetch(Environment context, PersistentResourceFetcher fetcher) {
         if (isHistorySelection(context.field)) {
             return new HistoryContainer(context);
+        } else {
+            // Not a revision request
+            // TODO: Clean this up.
+            context.requestScope.setHistoricalRevision(null);
+            context.requestScope.setHistoricalDatestamp(null);
         }
         EntityDictionary dictionary = context.requestScope.getDictionary();
         Class<?> entityClass = dictionary.getEntityClass(context.field.getName());