Remove export assignment from ink.d.ts #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in y-lohse#959, there is an incompatibility between how this declaration file is structured and the expectations of TypeScript. Removing the export assignment ensures that only the default symbol is exported. ``` An export assignment cannot be used in a module with other exported elements. ```
These relative paths were expecting the file to be nested inside the /src directory, but it is in the project root directory.
|
Merged. Ask away if you need guidance/info ! |
|
Merci! Confirmed working in the typescript project where I first noticed the issue. I’ll ask additional questions in a separate issue thread. |
maetl
added a commit
to maetl/inkjs
that referenced
this pull request
Apr 6, 2024
Fixes a problem introduced in y-lohse#1049 where the relative imports changed to suit standalone references to these files on disk—but overlooked that the tsconfig had `src` already mapped.
maetl
added a commit
to maetl/inkjs
that referenced
this pull request
Apr 6, 2024
Fixes a problem introduced in y-lohse#1049 where the relative imports changed to suit standalone references to these files on disk—but overlooked that the tsconfig had `src` already mapped.
maetl
added a commit
to maetl/inkjs
that referenced
this pull request
Apr 6, 2024
Fixes a problem introduced in y-lohse#1049 where the relative imports changed to suit standalone references to these files on disk—but overlooked that the tsconfig had `src` already mapped.
maetl
added a commit
to maetl/inkjs
that referenced
this pull request
Apr 6, 2024
Fixes a problem introduced in y-lohse#1049 where the relative imports changed to suit standalone references to these files on disk—but overlooked that the tsconfig had `src` already mapped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #959, there is an incompatibility between how this declaration file is structured and the expectations of recent TypeScript versions.
Removing the export assignment ensures that only the default symbol is exported.
Perhaps a better long term solution would be to upgrade the version of TypeScript used in the project. Happy to help with this if I can get a bit of guidance around where to start and managing build tools.
Checklist
npm test).npm run-script lint).