Added stream.CloseWithError(error) method for ability to send error on another side #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sintanial
changed the title
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 83.47% 82.25% -1.22%
==========================================
Files 6 6
Lines 708 744 +36
==========================================
+ Hits 591 612 +21
- Misses 97 109 +12
- Partials 20 23 +3
Continue to review full report at Codecov.
|
|
this is an incompatible change, the data after fin will terminate this connetion for old version. |
|
Mmm we may not send data for version 1 |
|
Add condition for v2 only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
stream.CloseWithError(error)method for ability to send error on another sideSometimes you need to understand reason of why a particular stream was closed by another side
This is useful for both: tests and business logic.
If there is a suggestion on how to improve or ideas on how to pass an error interface instead of string, I’m ready to fix it ;)