Fix memory leak in object streams by reusing the same packet instance #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally update main branch with 0.11.x version features (336 commits) so that my github profile page lights up like a christmas tree and I can start updating the readme files
Update readme branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instances of
HeartbeatPacketandEarthquakesRequestPacketare sent periodically during a connection. However, these two record classes carry no additional information, so it is safe to reuse a single instance for each of them. AsObjectInputStreams andObjectOutputStreams track all instances involved in them, this can improve memory usage of the application.