Adding Search Bar to Station Select UI #115

lab596 · 2023-09-01T19:00:06Z

Work in progress of adding and implementing Search Bar into Select Station UI.

Updating

updating

lab596 · 2023-09-02T23:04:17Z

Closes issue #100

* Adding Text Suggestions * Update SearchBar.java

lab596

Hey, I wanted to make this PR ready for review as I believe I am in a spot where I could use some assistance to wrap up this feature. In this review I have highlighted some of the main features left to fix/add. Please feal free to add any more suggestions/ optimization ideas.

lab596 · 2023-09-04T06:37:59Z

src/main/java/globalquake/ui/stationselect/SearchBar.java

+        //Attempting to change the color of the country borders
+        if (countryFound && foundCoordinates != null) {
+            g2.setColor(Color.GREEN);
+            g2.setStroke(new BasicStroke(2)); 
+            ArrayList<Polygon> paths = new ArrayList<>();
+
+            if(foundCoordinates instanceof org.geojson.Polygon){
+                Polygon pol = (org.geojson.Polygon) foundCoordinates;
+                paths.add(pol);
+            }
+            else if(foundCoordinates instanceof org.geojson.MultiPolygon){
+
+                MultiPolygon mp = (org.geojson.MultiPolygon) foundCoordinates;
+                List<List<List<org.geojson.LngLatAlt>>> polygons = mp.getCoordinates();
+                for (List<List<org.geojson.LngLatAlt>> polygon : polygons) {
+                    org.geojson.Polygon pol = new org.geojson.Polygon(polygon.get(0));
+                    paths.add(pol);
+                }
+            }
+            g2.setColor(Color.GREEN);
+            for (Polygon polygon : paths) {
+                List<org.geojson.LngLatAlt> coordinates = polygon.getExteriorRing();
+                int[] xPoints = new int[coordinates.size()];
+                int[] yPoints = new int[coordinates.size()];
+                for (int i = 0; i < coordinates.size(); i++) {
+                    org.geojson.LngLatAlt point = coordinates.get(i);
+                    xPoints[i] = (int) point.getLongitude();
+                    yPoints[i] = (int) point.getLatitude();
+                }
+                g2.fillPolygon(xPoints, yPoints, coordinates.size());
+            }
+        }


Here I am attempting to redraw the nation that has been searched with a different color in order to highlight that nation. The goal is to make the searched country more easily identifiable. While this code runs without errors, it does not change the nation's color and I need help debugging. I believe the reason behind the color not changing is that some classes (I believe GlobeRenderer.java) needs to be refreshed or revalidated in some manner.

Eventually, the goal is to also automatically take users to the country on the globe.

I see what you are trying to achieve, but this filling method will definitely not work, because the raw geojson polygon coordinates are saved as latitude/longitude and in order to calculate the actual screen coordinates, the polygon has to go trough 3D projection matrix etc...

I would suggest working improving the UI/other things now before I modify the rendering engine a bit to allow setting properties to the individual render entities. My idea is that each render entity would have a map of properties, and you can for example create a property called isHighlighted and use it while rendering to set maybe different colors/thicker line.

Also I want to work soon on the events zooming / cinema mode, so your country zooming might use the same API.

src/main/java/globalquake/ui/stationselect/SearchBar.java

src/main/resources/search_suggestions/countries.txt

src/main/java/globalquake/ui/stationselect/StationSelectFrame.java

xspanger3770 · 2023-09-04T08:00:11Z

Hi again! I see there is some great work being done! I tested the search bar and for the first attempt, it looks promising! Of course there is still a lot of improvements to done and I will try to lead you what can be done in my comments.

lab596 · 2023-09-05T06:02:57Z

I wanted to add a few notes:

Upon updating the countries.txt, 2 nations had special characters which I added to the file. However, as seen by the commit previous, this caused a build error, specifically a Error: Can't use 'tar -xzf' extract archive file. This shouldn't be a big deal, but it's just something I noticed.
Just as a note, the code as marked in the first review that attempted to highlight the nation may cause the shape of the nation to appear in the search bar. This is not intended and should eventually be fixed when the highlight feature is added correctly. If you wish to see this, I especially noticed it clearly when I searched "India" in the search bar.

Also, I was wondering if you had any UI features for the search bar that you wish to implement. If so, please provide an example as well as an image if possible so I can try to recreate it as best I can :)

xspanger3770 · 2023-09-12T20:06:17Z

Hi!
Sorry that I haven't looked at your PR in the past few days, I was pretty busy with all the other stuff and also the search bar feature feels pretty difficult to implement in a nice way for me at this moment and I didn't know how to help. Also, I knew I would be changing the polygon files in the near future that contain the country names and later I added more region borders. The new polygons could also be used for the search bar. Actually, you won't probably need the search suggestions.txt file, but you can create the list from already loaded polygons in Regions.java. There is for example regionsHD list, that contains all countries together with the polygons that you can use to fetch the coordinates that the globe would then zoom into using my new smoothTransition API.

Tell me what you think :) You can maybe have a look inside the Regions.java file to see how I handle the polygons, but overall this feature will require quite lot of work and I have dozens of other features that are requested by many people every day :D

lab596 · 2023-09-28T00:16:43Z

Please let me know when is a good time to resume work on this PR :)

xspanger3770 · 2023-09-30T18:50:44Z

I sure will :) Not yet though as we want to add more regions soon that can be used for the search bar, and I'm pretty busy with university. Also there is absolutely nothing wrong about if you try to implement some other smaller feature in the meantime :)

lab596 added 3 commits September 1, 2023 11:55

Adding Search Bar

6b90fa0

Merge pull request #2 from xspanger3770/main

c897f6a

Updating

Create SearchBar.java

4e3476d

lab596 changed the title ~~Lab596 patch 1~~ Adding Search Bar to Station Select UI Sep 1, 2023

lab596 marked this pull request as draft September 1, 2023 19:01

lab596 added 4 commits September 2, 2023 15:49

Updating Dependancies & Resources

91e5a0a

Merge branch 'main' of https://github.com/lab596/GlobalQuake

21cd9ae

Merge pull request #3 from lab596/main

a9ca5d1

updating

Update SearchBar.java

2b70475

lab596 added 4 commits September 2, 2023 21:07

Adding Text Autofill Suggestions (#5)

decbdf2

* Adding Text Suggestions * Update SearchBar.java

Update SearchBar.java

6b5fb94

Update SearchBar.java

7c24420

Update SearchBar.java

355fb0e

lab596 marked this pull request as ready for review September 4, 2023 06:30

lab596 commented Sep 4, 2023

View reviewed changes

lab596 added 2 commits September 4, 2023 21:37

Adding Country search Verification

16a6114

Prevent Build Error

a6caac3

Adding Layered Panel

46a6a57

lab596 requested a review from xspanger3770 September 12, 2023 18:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Search Bar to Station Select UI #115

Adding Search Bar to Station Select UI #115

lab596 commented Sep 1, 2023 •

edited

lab596 commented Sep 2, 2023

lab596 left a comment

lab596 Sep 4, 2023

lab596 Sep 4, 2023

xspanger3770 Sep 4, 2023

xspanger3770 Sep 4, 2023

xspanger3770 commented Sep 4, 2023

lab596 commented Sep 5, 2023

xspanger3770 commented Sep 12, 2023

lab596 commented Sep 28, 2023

xspanger3770 commented Sep 30, 2023

Adding Search Bar to Station Select UI #115

Are you sure you want to change the base?

Adding Search Bar to Station Select UI #115

Conversation

lab596 commented Sep 1, 2023 • edited

lab596 commented Sep 2, 2023

lab596 left a comment

Choose a reason for hiding this comment

lab596 Sep 4, 2023

Choose a reason for hiding this comment

lab596 Sep 4, 2023

Choose a reason for hiding this comment

xspanger3770 Sep 4, 2023

Choose a reason for hiding this comment

xspanger3770 Sep 4, 2023

Choose a reason for hiding this comment

xspanger3770 commented Sep 4, 2023

lab596 commented Sep 5, 2023

xspanger3770 commented Sep 12, 2023

lab596 commented Sep 28, 2023

xspanger3770 commented Sep 30, 2023

lab596 commented Sep 1, 2023 •

edited