XEP-0353: Jingle Message Initiation -> Call Invite Message #1155

mar-v-in · 2022-01-30T15:37:37Z

Restrict to calls only, removing non-call Jingle functionality (as discussed in Council)
Support multiple and non-Jingle session establishment methods (derived from Call Invites ProtoXEP)
Adjust title and namespace
Define Jingle-independent set of conditions for <reason>
Add disco (from XEP-0353: add disco (based upon PR #1141) #1142)
Add remark about random IDs (from XEP-0353: add disco (based upon PR #1141) #1142)

Rendered: https://larma.de/xeps/xep-0353.html
Diff: https://larma.de/xeps/xep-0353-diff.html

- Restrict to calls only, removing non-call Jingle functionality - Support multiple and non-Jingle session establishment methods - Adjust title and namespace - Define Jingle-independent set of conditions for <reason>

As of xsf/xeps#1155

mar-v-in · 2022-02-08T21:46:27Z

@fippo @stpeter Can you review this, please?

fippo

a couple of questions inline.

Overall I do not think bringing groupchat into this is a good idea.

fippo · 2022-02-17T07:21:26Z

xep-0353.xml

-    <example caption="Initiator Sends Intent Message"><![CDATA[
+  <p>
+    All &MESSAGE; stanzas exchanged by this protocol MUST be of type="chat" when
+    sent in a direct message or of type="groupchat" when sent to a group chat


nit: making this a list will be easier to read

fippo · 2022-02-17T07:33:07Z

xep-0353.xml

 <message from='romeo@montague.example/orchard'
         to='juliet@capulet.example'
         type='chat'>
-  <propose xmlns='urn:xmpp:jingle-message:1' id='a73sjjvkla37jfea'>
-    <description xmlns='urn:xmpp:jingle:apps:rtp:1' media='audio'/>
+  <propose xmlns='urn:xmpp:call-message:1' id='a73sjjvkla37jfea' audio='true' video='false' multi='false'>


nit: we usually start counting namespaces at :0, no?

fippo · 2022-02-17T07:34:55Z

xep-0353.xml

  <example caption="One of Responder's Resources Accepts the Call"><![CDATA[
 <message from='juliet@capulet.example/phone'
         to='romeo@montague.example'
         type='chat'>
-  <accept xmlns='urn:xmpp:jingle-message:1' id='a73sjjvkla37jfea'/>
+  <accept xmlns='urn:xmpp:call-message:1' id='a73sjjvkla37jfea'>


nit: the first id is obsolete here, no?

The id of <accept> is referring to the id of a <propose>, the sid of the <jingle> element in <accept> is indeed redundant, as it is the reflected element from the <propose> message.

fippo · 2022-02-17T07:36:04Z

xep-0353.xml

-  <p>Next, the device from which Juliet accepted the call sends directed presence to Romeo for the reasons described above.</p>
+  <p>
+    Juliet's server broadcasts this accept message to all of her resources (as
+    described in &xep0280; or, e.g. &xep0045;, respectively), which stop ringing, and


I don't see how MUC plays a role in this part.

fippo · 2022-02-17T07:38:09Z

xep-0353.xml

-      <busy/>
-      <text>Busy</text>
-    </reason>
+  <reject xmlns='urn:xmpp:call-message:1' id='a73sjjvkla37jfea'>


if you put the sid into a subelement above you'll need to do this here too.

fippo · 2022-02-17T08:29:41Z

xep-0353.xml

-    <example caption="Initiator Sends Finish Message"><![CDATA[
+    <p>
+      This protocol in conjunction with &xep0280; and &xep0313; or appropriate
+      groupchat protocols (like &xep0045;) allows all devices of all involved


I don't see how this solves a problem in MUC where the full JIDs are known.

I don't understand what you mean here. Synchronizing the call state via messages works independently of full JIDs being used in MUCs or not. MUCs do however help with synchronization by providing message history (although nowadays we typically use MAM there as well) and forwarding the messages to all other participating resources in the room (which include your own other devices).

xep-0353.xml

mar-v-in · 2022-02-17T21:42:27Z

@fippo I guess inviting a group of people to a call is a feature we want, no? Do you think this should always happen with a bunch of direct messages instead of a groupchat message?

PS: Based on feedback outside GitHub I'll also rephrase a few bits that maybe were a bit unclear.

Kev · 2023-03-31T10:12:24Z

Seems to have conflicts.

tmolitor-stud-tu and others added 4 commits January 28, 2022 23:29

Add disco support

5cd3e79

Make sure 'id' attributes are sufficitently random

f05da64

Migrate to Call Invite Messages

221c573

- Restrict to calls only, removing non-call Jingle functionality - Support multiple and non-Jingle session establishment methods - Adjust title and namespace - Define Jingle-independent set of conditions for <reason>

Add revision block

9a94098

mar-v-in changed the title ~~Call invite message~~ XEP-0353: Call invite message Jan 30, 2022

mar-v-in changed the title ~~XEP-0353: Call invite message~~ XEP-0353: Jingle Message Initiation -> Call Invite Message Jan 30, 2022

fiaxh added a commit to dino/dino that referenced this pull request Feb 7, 2022

Add support for call invite messages

071d925

As of xsf/xeps#1155

mar-v-in marked this pull request as ready for review February 8, 2022 21:39

horazont added the Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. label Feb 15, 2022

fippo reviewed Feb 17, 2022

View reviewed changes

melvo mentioned this pull request Aug 6, 2022

Update XEP-0272 Muji #1139

Draft

Kev added the Needs Changes label Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XEP-0353: Jingle Message Initiation -> Call Invite Message #1155

XEP-0353: Jingle Message Initiation -> Call Invite Message #1155

mar-v-in commented Jan 30, 2022

mar-v-in commented Feb 8, 2022

fippo left a comment

fippo Feb 17, 2022

fippo Feb 17, 2022

fippo Feb 17, 2022

mar-v-in Feb 17, 2022

fippo Feb 17, 2022

fippo Feb 17, 2022

fippo Feb 17, 2022

mar-v-in Feb 17, 2022

mar-v-in commented Feb 17, 2022 •

edited

Kev commented Mar 31, 2023

XEP-0353: Jingle Message Initiation -> Call Invite Message #1155

Are you sure you want to change the base?

XEP-0353: Jingle Message Initiation -> Call Invite Message #1155

Conversation

mar-v-in commented Jan 30, 2022

mar-v-in commented Feb 8, 2022

fippo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mar-v-in commented Feb 17, 2022 • edited

Kev commented Mar 31, 2023

mar-v-in commented Feb 17, 2022 •

edited