Reorganize Makefile, allowing MacOS & Linux build from a single makefile. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat I've done to improve usability
… to use the main one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was installing this for my research lab and noticed some potential improvements.
This PR reorganizes the Makefile to use overridable variables, and also makes it easier to apply the same property flags to the compiler for all targets.
Additionally, it lets the single primary Makefile be used to build for MacOS or Linux.
Finally, this fixes a bug that I noticed where the Makefile as it existed previously was not setting
-O3on the compile step, meaning that the previously generated binaries were not optimized.I'm planning to create a similar PR for https://github.com/xqwen/torus/
Thanks for taking a look!