Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction: left argument to decode for seconds to days/hours... #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonocarroll
Copy link

Thanks for this resource, I'm very much enjoying reading it and following along on tryapl.org

I wanted to try my own version for the decode example and was confused that 9e4 seconds (exactly 25 hours) produced 0 1 0 0. The left argument of the decode should (I believe) be 0 24 60 60 in which case the result is, as expected, 1 1 0 0.

For the example you used (1e4) it didn't matter, but trying a number greater than 86399 (1 day or larger) will give the wrong answer.

I don't think it matters for the example following (both vectors produce the same results) but for consistency, I changed that, too.

As for why that should be 0 and not 1 - an explanation of that would be wonderful because I'm not entirely sure I understand it.

@jonocarroll
Copy link
Author

Funnily enough, this timely video explains the "no overflow to a higher unit" behind the 0 https://youtu.be/hQFMjRPFioI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant